return jinja2 template environment per docs #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the alias 'jinja2' to look up the jinja2 template engine per https://docs.djangoproject.com/en/1.9/topics/templates/#django.template.loader.engines
| engine = engines[0] | ||
| return engine.env | ||
| from django.template import engines | ||
| return engines[alias].env |
There was a problem hiding this comment.
I'm all for that change, but it means the exception we catch below isn't quite right. It should be IndexError, right ? Do you think you can try adding a test for that ? Something that overrides settings to omit jinja2 template configuration and then tries to access COMPRESS_JINJA2_GET_ENVIRONMENT ?
There was a problem hiding this comment.
I will check again but I thought when I looked it up before the engines object raises the custom exception instead of indexerror. I'm travelling so I am not going to be able to get to this right away
There was a problem hiding this comment.
You're right actually, totally forgot about that.
diox
added a commit
that referenced
this pull request
Jan 22, 2016
return jinja2 template environment per docs
diox
added a commit
that referenced
this pull request
Jan 22, 2016
(I merged #726 into master by accident)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the alias 'jinja2' to look up the jinja2 template engine per https://docs.djangoproject.com/en/1.9/topics/templates/#django.template.loader.engines
fix #637