Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test coverage reporting #5

Merged
merged 7 commits into from
Jun 7, 2020

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Apr 27, 2020

🤞 CodeCov will respond.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b9be797). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   56.95%           
=========================================
  Files             ?        7           
  Lines             ?      223           
  Branches          ?       31           
=========================================
  Hits              ?      127           
  Misses            ?       86           
  Partials          ?       10           
Flag Coverage Δ
#unittests 56.95% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9be797...4ebe349. Read the comment docs.

@smithdc1
Copy link
Member Author

I've tried to add coverage to the templates, as that is mostly what this package will be.

This isn't currently working as expected 😕

  • Coverage Report gives coverage for all the files (incl. templates) (detail in GH Action logs)
  • They are in the current working directory (detail in GH Action logs)
  • But are not appearing in codecov
  • The Upload file shows coverage data for templates... but files are missing from the network section at the top. 🤷

May need to ask codecov support, unless anyone has any ideas?

@carltongibson
Copy link
Contributor

...unless anyone has any ideas?

None immediately, sorry. 🙂 — I'd need to look into it.

@smithdc1
Copy link
Member Author

None immediately, sorry. 🙂 — I'd need to look into it.

I've asked codecov support, let's see what they say.

https://community.codecov.io/t/missing-coverage-data/1357

@thomasrockhu
Copy link

Hi, Tom from Codecov here, sorry that it's been taking a while for us to get back to you. I'll get back to you on the community thread today.

@thomasrockhu
Copy link

Hi @smithdc1, just confirming that we patched the bash uploader with a new flag -X html. Please add this when calling Codecov, and it should parse the coverage on those files. Let me know if that doesn't work as expected.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@bee47a9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   29.12%           
=========================================
  Files             ?       35           
  Lines             ?      570           
  Branches          ?       25           
=========================================
  Hits              ?      166           
  Misses            ?      395           
  Partials          ?        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee47a9...89ee83f. Read the comment docs.

@smithdc1
Copy link
Member Author

smithdc1 commented Jun 2, 2020

Hi @thomasrockhu,

Super thanks for your help. 👏

This has worked now (https://codecov.io/gh/django-crispy-forms/crispy-tailwind/pull/5/tree?path=crispy_tailwind%2Ftemplates%2Ftailwind%2Flayout)

Although there is now a bit of work to do to with the coverage % 🙈

p.s. using the bash uploader was easier than the github action 😄

@thomasrockhu
Copy link

thomasrockhu commented Jun 2, 2020

@smithdc1 Amazing! Glad it worked out for you. We currently maintain the bash uploader more, but we'd love to get feedback on the GitHub Action. What would have made using the Action easier for you?

@smithdc1 smithdc1 merged commit 05933a9 into django-crispy-forms:master Jun 7, 2020
@smithdc1
Copy link
Member Author

smithdc1 commented Jun 7, 2020

Hi @thomasrockhu
There may be a bit of comparing different times. GH have only recently released the API to enable uploads from public repos without a token.

This time I needed to enable this additional setting for coverage to work on HTML. I had a quick look at the docs but couldn't see how to pass settings onto the bash uploader?

@thomasrockhu
Copy link

Yes, it's something that we are aware of and working around for. Thanks for bringing it up, I'll try to prod about passing along other arguments down from the action

@smithdc1 smithdc1 added this to the 0.1 Release milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants