-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test coverage reporting #5
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 56.95%
=========================================
Files ? 7
Lines ? 223
Branches ? 31
=========================================
Hits ? 127
Misses ? 86
Partials ? 10
Continue to review full report at Codecov.
|
I've tried to add coverage to the templates, as that is mostly what this package will be. This isn't currently working as expected 😕
May need to ask codecov support, unless anyone has any ideas? |
None immediately, sorry. 🙂 — I'd need to look into it. |
I've asked codecov support, let's see what they say. |
Hi, Tom from Codecov here, sorry that it's been taking a while for us to get back to you. I'll get back to you on the community thread today. |
Hi @smithdc1, just confirming that we patched the bash uploader with a new flag |
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 29.12%
=========================================
Files ? 35
Lines ? 570
Branches ? 25
=========================================
Hits ? 166
Misses ? 395
Partials ? 9 Continue to review full report at Codecov.
|
Hi @thomasrockhu, Super thanks for your help. 👏 This has worked now (https://codecov.io/gh/django-crispy-forms/crispy-tailwind/pull/5/tree?path=crispy_tailwind%2Ftemplates%2Ftailwind%2Flayout) Although there is now a bit of work to do to with the coverage % 🙈 p.s. using the bash uploader was easier than the github action 😄 |
@smithdc1 Amazing! Glad it worked out for you. We currently maintain the bash uploader more, but we'd love to get feedback on the GitHub Action. What would have made using the Action easier for you? |
Hi @thomasrockhu This time I needed to enable this additional setting for coverage to work on HTML. I had a quick look at the docs but couldn't see how to pass settings onto the bash uploader? |
Yes, it's something that we are aware of and working around for. Thanks for bringing it up, I'll try to prod about passing along other arguments down from the action |
🤞 CodeCov will respond.