Create a bootstrap modal layout object

[nsandler1]

Introduces bootstrap modals into crispy forms as a layout object.

Supported by Bootstrap v3+

[smithdc1]

Thanks for this, it looks like a nice addition.

Could I ask you to have a look at updating the docs, and adding some tests?

Here's a commit that shows how we're currently writing tests. The aim is with this style that it makes them easier to test than lots of HTML in Python strings.

Do let me know if you need any help with these.

[codecov-commenter]

Codecov Report

Merging #1204 (88388cc) into main (e84b43f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   97.35%   97.38%   +0.03%     
==========================================
  Files          23       23              
  Lines        2909     2950      +41     
  Branches      327      328       +1     
==========================================
+ Hits         2832     2873      +41     
  Misses         39       39              
  Partials       38       38              

Flag	Coverage Δ
unittests	97.38% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
crispy_forms/bootstrap.py	91.58% <100.00%> (+0.72%)	⬆️
crispy_forms/tests/test_layout_objects.py	98.50% <100.00%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84b43f...88388cc. Read the comment docs.

[nsandler1]

@smithdc1 Of course! I wanted to hold off on updating the docs and writing tests until my pull request got attention. Thanks for the example.

[nsandler1]

Modals are only supported by bootstrap 3 and 4 with no changes between the versions that would cause incompatibility. f1a8382 only tests bootstrap3 modals and the assumption is a bootstrap4 modal would work the same. If a test for bootstrap4 is requested I'm more than willing to add one, though it would be the exact same test as bootstrap3, just with the bootstrap4 decorator.

[nsandler1]

@smithdc1 I'm a bit stuck with how to pass the Python 3.7 check. Any ideas?

[smithdc1]

Ah yes, the whole space "thing" with Django 2.2. Not long left to support this version.

Adding a couple of spaces to the tests should fix it.

This is now top of my list to have a look at, looks great a a first glance!

[smithdc1]

Thanks again for the PR! 🏅

I've got a few notes, mostly nits and/or questions about some edge cases. Appreciate your thoughts on these.

[smithdc1]

Ok, tests are passing. Is there anything else before I merge?

[smithdc1]

@nsandler1 thanks for the contribution!

[nsandler1]

@smithdc1 Nope, looks good to me!

No problem!