Set Content-Lenght header after modifying content #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested it, but the code looks good to me. Just one thing: could you update the README please? |
|
What exactly would you like to see updated in the README? |
|
My apologies! I was thinking of updating the CHANGELOG with a short description of your change, but typed README instead. |
jaap3
force-pushed
the
set-content-length
branch
from
a39f1d2
to
e03af5a
Compare
In some cases the Content-Length header is set before modifying the content. Since these middlewares add more content to the response this causes certain clients (e.g. Selenium) to only partially read the response body.
jaap3
force-pushed
the
set-content-length
branch
from
e03af5a
to
ab0020f
Compare
|
@richardbarran Sorry for the delay, but finally I got around to updating the |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.