Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3.0 #275

Merged
merged 22 commits into from May 7, 2020
Merged

Django 3.0 #275

merged 22 commits into from May 7, 2020

Conversation

jaap3
Copy link
Member

@jaap3 jaap3 commented Dec 9, 2019

This add Django 3.0 support and drops Python 2 and Django < 2.2 support.

See also #271

Six is no longer bundled with Django >= 3.0
The context argument is no longer provided. Make the method signature
more flexible by just catering for *args and **kwargs.
Pillow doesn't seem to be used directly by fiber, so there's no
reason to mention it in the requirements
Failed in Django 3.0 with TypeError: unhashable type: 'list'
ugettext has been deprecated in Django 3.0 and will be removed
in Django 4.0
The future is now
The *_text functions have been deprecated in Django 3.0 and
will be removed in Django 4.0
@richardbarran
Copy link
Member

Hi @jaap3 - what is the current status on this PR? Are you still working on it, or are you busy elsewhere and you cannot continue at present on Django 3.0 stuff?

@jaap3
Copy link
Member Author

jaap3 commented Jan 6, 2020

I was waiting for all dependencies to become Django 3.0 compatible (and enjoying the christmas break). Everything seems good to go now.

@jaap3 jaap3 changed the title [WIP] Django 3.0 Django 3.0 Jan 6, 2020
@richardbarran
Copy link
Member

My apologies - I missed the updates on this thread.
I've deployed this branch to a production website that I run, no issues to report. I'm happy to merge.

@richardbarran richardbarran mentioned this pull request May 7, 2020
@richardbarran richardbarran merged commit 498d2d0 into master May 7, 2020
@richardbarran
Copy link
Member

@jaap3 I've merged in this PR - I'll make a new release of Django-fiber in the next few days.

@jaap3
Copy link
Member Author

jaap3 commented May 8, 2020

Thank you, no worries about the delay :)

@153957 153957 deleted the django-3.0 branch May 8, 2020 13:50
@richardbarran
Copy link
Member

I've just released django-fiber 1.7 with your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants