Apply suggestions from code review

Co-authored-by: Michael <michael-k@users.noreply.github.com>
django-guardian · Aug 4, 2020 · ee8200a · ee8200a
1 parent 753c13e
commit ee8200a
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/guardian/core.py b/guardian/core.py
@@ -158,9 +158,7 @@ def get_perms(self, obj):
                 return []
             if self.user and self.user.is_superuser:
                 perms = list(
-                    chain.from_iterable(
-                        Permission.objects.filter(content_type=ctype).values_list("codename")
-                    )
+                    Permission.objects.filter(content_type=ctype).values_list("codename", flat=True)
                 )
             elif self.user:
                 # Query user and group permissions separately and then combine
@@ -195,9 +193,7 @@ def prefetch_perms(self, objects):
 
         if self.user and self.user.is_superuser:
             perms = list(
-                chain.from_iterable(
-                    Permission.objects.filter(content_type=ctype).values_list("codename")
-                )
+                Permission.objects.filter(content_type=ctype).values_list("codename", flat=True)
             )
 
             for pk in pks: