Reduce memory usage of clean_orphan_obj_perms #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use .iterator() on QuerySet to limit memory usage and avoid Django to cache all objects.
|
Thanks, that definitely makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use generic FK for your permission and don't yet (shame on us :)) delete permission object when object is deleted.
Therefor we use from time to time clean_orphan_obj_perms... but it iterate over ALL permission objects, and we have quiet a lots of them (about 100k)... this cause clean_orphan_obj_perms to cache all objects and consume way to much memory (multiple Gb).
This is a known issue of Django with a known solution: use iterator.
This PR use iterator() for clean_orphan_obj_perms when iterating over all permission objects.