-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Django 1.9 updates and fixes #1277
Conversation
|
|
|
…and update_index commands
|
django.conf.urls.patterns
as it'll be removed in Django 2.0
|
|
|
|
|
This is looking promising – the last failure is probably just a minor change to related to the command-line processing cleanup: https://travis-ci.org/django-haystack/django-haystack/jobs/93071939#L1408-L1424 |
|
Some news of this PR @mariocesar ? |
@gustavi I neglect this branch for some weeks, Sorry :( It needs some minor refactor to make it work, Will try to make it the next week. If you want to help, there are renaming and fixing imports issues, there are not big problems. Just make a PR for my patch branch |
Thanks for working on this @mariocesar! |
Sorry @mariocesar but I don"t know the code. But this is really a bloquer for our project. |
No news ? |
(?P<year>\d{4})- | ||
(?P<month>\d{2})- | ||
(?P<day>\d{2}) | ||
(T|\s+) # Time flag or an space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this comment is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean \s+ ? Could be better, one space chars or more
I'm back! |
As I already commented on #1300, I fixed the last test failures in my fork: https://github.com/sk1p/django-haystack/tree/django_19, feel free to merge these changes into your pull request (might need the changes from #1300, too). |
Sorry about the delays but as of 10bcc76 the tests are passing on Django 1.9. If you have any remaining gaps please either rebase against master or close this & open a separate pull request. |
Thanks for your efforts! |
Remove
django.conf.urls.patterns
, since they already have been removed from the doc and will be removed in Django 2.0This removes in Django 1.9 the warning:
Also Updates the command
update_index
to match new arguments parser in Django