Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Django 1.9 updates and fixes #1277

Closed
wants to merge 16 commits into from

Conversation

mariocesar
Copy link
Contributor

Remove django.conf.urls.patterns, since they already have been removed from the doc and will be removed in Django 2.0

This removes in Django 1.9 the warning:

RemovedInDjango110Warning: django.conf.urls.patterns()
is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of
django.conf.urls.url() instances instead.
  name='redactor_upload_file'),

Also Updates the command update_index to match new arguments parser in Django

@landscape-bot
Copy link

Code Health
Repository health increased by 0.01% when pulling f8eda4c on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.04% when pulling ea6b4bc on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.09% when pulling dfb0ae8 on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.04% when pulling d9974c5 on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@mariocesar mariocesar changed the title Remove django.conf.urls.patterns as it'll be removed in Django 2.0 Django 1.9 updates and fixes Nov 24, 2015
@landscape-bot
Copy link

Code Health
Repository health increased by 0.27% when pulling 48fc33a on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.32% when pulling 200895c on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.30% when pulling bdd668d on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.32% when pulling 11e8fbd on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.33% when pulling 892e086 on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@acdha
Copy link
Contributor

acdha commented Nov 25, 2015

This is looking promising – the last failure is probably just a minor change to related to the command-line processing cleanup:

https://travis-ci.org/django-haystack/django-haystack/jobs/93071939#L1408-L1424

@landscape-bot
Copy link

Code Health
Repository health increased by 0.39% when pulling 3ac5fab on mariocesar:patch-2 into 3b453b3 on django-haystack:master.

@gustavi
Copy link

gustavi commented Dec 26, 2015

Some news of this PR @mariocesar ?

@mariocesar
Copy link
Contributor Author

@gustavi I neglect this branch for some weeks, Sorry :(

It needs some minor refactor to make it work, Will try to make it the next week.

If you want to help, there are renaming and fixing imports issues, there are not big problems. Just make a PR for my patch branch

@joshowen
Copy link

Thanks for working on this @mariocesar!

@gustavi
Copy link

gustavi commented Jan 5, 2016

Sorry @mariocesar but I don"t know the code. But this is really a bloquer for our project.

@gustavi
Copy link

gustavi commented Jan 13, 2016

No news ?

(?P<year>\d{4})-
(?P<month>\d{2})-
(?P<day>\d{2})
(T|\s+) # Time flag or an space
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this comment is correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean \s+ ? Could be better, one space chars or more

@gustavi gustavi mentioned this pull request Jan 20, 2016
@acdha acdha changed the title Django 1.9 updates and fixes WIP: Django 1.9 updates and fixes Jan 20, 2016
@acdha acdha self-assigned this Jan 20, 2016
@acdha acdha added this to the v2.5.0 milestone Jan 20, 2016
@mariocesar
Copy link
Contributor Author

I'm back!

@mariocesar mariocesar closed this Feb 12, 2016
@mariocesar mariocesar reopened this Feb 12, 2016
@sk1p
Copy link
Contributor

sk1p commented Mar 1, 2016

As I already commented on #1300, I fixed the last test failures in my fork: https://github.com/sk1p/django-haystack/tree/django_19, feel free to merge these changes into your pull request (might need the changes from #1300, too).

@acdha
Copy link
Contributor

acdha commented Mar 25, 2016

Sorry about the delays but as of 10bcc76 the tests are passing on Django 1.9. If you have any remaining gaps please either rebase against master or close this & open a separate pull request.

@acdha acdha closed this Mar 25, 2016
@Gesias
Copy link

Gesias commented Apr 9, 2016

Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants