Queryset cache using sparse list update #1682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sparse list implementation avoids allocating the result cache elements until something triggers loading the actual content. This has a slight memory increase for very small querysets – roughly a custom class + dict() vs. a list() – but the actual result data will usually be much larger and the difference is cancelled out by the time the result cache is at a thousand items. This branch is currently broken using the released version of sparse_list – see johnsyweb/python_sparse_list#5
This bit of code really needs to be rewritten to avoid the loop but this patch at least hits the point of being testable on Python 2
Following a rapid upstream release, this should get the tests in django-haystack#1117 to pass against Python 3.
wetneb
force-pushed
the
queryset-cache-using-sparse_list-update
branch
from
a30d37d
to
b18a1df
Compare
|
Tests are currently failing because of johnsyweb/python_sparse_list#12. |
acdha
previously approved these changes
Aug 19, 2019
acdha
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of #1451, using the released version of
sparse_list.I will test this in production and report back.