Add accepts empty values #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restyled is making substantial changes to parts of the code I did not touch. Travis CI seems stalled. Please let me know if any changes are needed to merge this PR in. Closes #261 |
When building the Solr document, empty values will not be skipped if they are also present in the fieldUpdates. Tests are included.
mitchelljkotler
force-pushed
the
261-add-accept-empty-values-with-field-update
branch
from
c84688b
to
57afc5a
Compare
|
Any chance this can be reviewed and merged in? |
acdha
approved these changes
Jan 9, 2021
|
Sorry about that. I just merged it. |
|
Thanks!
…On Fri, Jan 8, 2021, 7:25 PM Chris Adams ***@***.***> wrote:
Sorry about that. I just merged it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBHITHTHH6SZ62TBGHV3LSY6O65ANCNFSM4UJKEBHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the Solr document, empty values will not be skipped if
they are also present in the fieldUpdates. Tests are included.