No proper way to create customizable ModelResource

[andreynovikov]

I needed to customize my ModelResource behavior for each import. The most straightforward way is to add extra field to ImportForm. But there is no way to access form data from ModelResource.

The first issue is that get_import_resource_kwargs knows nothing about import forms. Thanks it knows about request. So the first ugly hack was to recreate and re-validate my custom import form inside this method.

But the next issue is even worse: custom field value from ImportForm should be passed through ConfirmImportForm but the solution from documentation can not work. See:

django-import-export/import_export/admin.py

Line 322 in 3cf5e3f

initial = self.get_form_kwargs(form=form, **initial)

Fortunately there is currently a typo in this line, it obviously should be:

initial = self.get_form_kwargs(form=confirm_form, **initial)

This typo makes possible second ugly hack to access ImportForm data to initialize ConfirmImportForm. But when you will fix it there would be no way to do that.

I suggest this part of import workflow should be redesigned.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mgrdcm]

@andreynovikov I think this might be solved now in 2.1.0 by #994 and #1108. Can you confirm?

[imomaliev]

Should be fixed by #1185

[andrewgy8]

This seems to be solved. I will close it for now.