Pass form into get_import_data_kwargs #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the preview dry run, the ImportForm is passed into Resource.get_import_data_kwargs. However, during the actual import phase the ConfirmImportForm is not passed into the same method. This changes that. Use case: getting data from the confirm form into the resource's import process.
1 similar comment
andrewgy8
approved these changes
Apr 26, 2020
ZuluPro
pushed a commit
to ZuluPro/django-import-export
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During the preview dry run, the ImportForm is passed into Resource.get_import_data_kwargs. However, during the actual import phase the ConfirmImportForm is not passed into the same method. This means there's no way to get values set in the ConfirmImportForm into the Resource's import process.
Solution
Passing the confirm form into
get_import_data_kwargsduring the actual import process.Acceptance Criteria
There are no existing tests that cover this, and no appropriate documentation to update. I don't think a test case for this is warranted but let me know if I'm wrong!