added skip_html_diff parameter #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
force-pushed
the
skip-html-diff
branch
2 times, most recently
from
86a715e
to
b4de68e
Compare
manelclos
approved these changes
Dec 6, 2021
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 6, 2021
matthewhegarty
force-pushed
the
skip-html-diff
branch
from
b4de68e
to
3dede05
Compare
matthewhegarty
force-pushed
the
skip-html-diff
branch
from
3dede05
to
e8a6639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a performance improvement when importing large numbers of rows.
If one is not using the Admin site, then there is no need for the
as_html()call to be made for each row.Solution
This PR adds a new meta attribute
skip_html_diffwhich is used to skip theas_html()call if enabled.I've also tested and documented the performance differences.
I also pulled in some of the documentation changes from #1274, including instructions on running performance tests using the supplied script.
Acceptance Criteria
I have added a new unit test and manually tested imports. Obviously the HTML report doesn't render on the confirmation page in the admin site if this is enabled, but import still works via the Admin site.