Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed django_extensions from example app settings. #1356

Conversation

matthewhegarty
Copy link
Contributor

Problem

Whilst testing #1329, I added django_extensions to settings.py so that the runscript command could be used during bulk testing. However, this causes a crash (see issue #1355) if the test.txt dependencies are not used.

Solution

  1. Removed django_extensions from settings.
  2. Updated bulk testing readme.md to clarify that this needs to be installed if testing.

Acceptance Criteria

  • Tested locally in a new virtualenv.
  • No new tests necessary.
  • Ran the existing test suite.

@matthewhegarty matthewhegarty force-pushed the remove-django_extensions-from-settings branch from 5a04abf to 98739b4 Compare December 8, 2021 10:07
@coveralls
Copy link

coveralls commented Dec 8, 2021

Coverage Status

Coverage remained the same at 98.073% when pulling 98739b4 on matthewhegarty:remove-django_extensions-from-settings into 1c32c8e on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 0bfe9c7 into django-import-export:main Dec 8, 2021
@matthewhegarty matthewhegarty deleted the remove-django_extensions-from-settings branch December 8, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants