New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added python3.10 to tox environment list #1336
Added python3.10 to tox environment list #1336
Conversation
Hi @matthewhegarty, looks the tests are not passing due to DeprecationWarning. Also not all tests are run, is this because one test failed? Would you mind creating your branches in this repository instead of in your fork? I could try some commits to this branch when/if I have spare time :) Thanks! |
Hi Manel, thanks for taking a look. I've marked it as draft because the issue is that the |
Have updated the "exclusion" matrix, so now python3.10 will only be used against Django main. |
ebfbf5b
to
50a51ac
Compare
50a51ac
to
e946e95
Compare
@manelclos I believe this is ok to be merged now - would you mind checking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Marked as draft until I can successfully test manually on 3.10 |
Manually tested on 3.10 (Ubuntu 20.04):
|
e946e95
to
c167156
Compare
Problem
Now that python 3.10 is available, I have added it to the list of supported python releases.
Whilst testing this, I noticed tox failures for >= 3.9 only, because support for pytz was dropped in that release. However, since pytz is still a dependency for Django, I added it to the import list in
test.txt
, since it is required fortest_widgets.py
.Solution
Acceptance Criteria
Ran full tox run through locally.