Fix for crash when deleting via admin site #1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I have verified that there is a crash if one tries to delete records using the admin site (see #432).
Solution
The fix is simple - to add instance attributes to the
RowResult
.This introduced some code duplication, so I added a minor refactor of
RowResult
to set attributes via a new method.conf.py
attributes (raised bymake lint
).pytz
dependency which is needed for testing with python 3.9 (see Added python3.10 to tox environment list #1336).books-for-delete.csv
Acceptance Criteria
test_admin_integration.py
)RowResult
method