Deprecate 'escape html' #1618
Merged
Deprecate 'escape html' #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With reference to #1602, it is more secure to escape exported HTML by default (rather than by setting an option). A future release of tablib will switch to ElementTree instead of MarkupPy which will do escaping by default.
This release deprecates the use of
IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT.Also, previously deprecated
IMPORT_EXPORT_ESCAPE_OUTPUT_ON_EXPORTis removed.This PR temporarily pins tablib to 3.5.0 so that the default HTML escaping behaviour of ElementTree can be introduced in a future release.