Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support of escape-output #17

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Remove support of escape-output #17

merged 3 commits into from
Sep 28, 2023

Conversation

yalef
Copy link
Contributor

@yalef yalef commented Sep 25, 2023

According import-export issue, escape_output parameter become deprecated during tablib update.
So it is need to be removed.

To reproduce run inv tests.run in main branch

@yalef yalef requested a review from ron8mcr September 25, 2023 17:37
@yalef yalef marked this pull request as ready for review September 25, 2023 17:42
ron8mcr
ron8mcr reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@ron8mcr ron8mcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing of deprecated IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT too?

@yalef
Copy link
Contributor Author

yalef commented Sep 26, 2023 •
edited
Loading

What do you think about removing of deprecated IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT too?

Hmm, I think we can rely on import-export package, and wait until they remove it.
IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT is deprecated because in future tablib will migrate to ElementTree, where html escaped by default. But this's didn't released yet, so IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT can be keeped

@yalef yalef requested a review from ron8mcr September 27, 2023 08:31
@yalef yalef merged commit 45978fa into main Sep 28, 2023
26 checks passed
@yalef yalef deleted the remove-escape-output branch December 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ron8mcr ron8mcr ron8mcr approved these changes

@NikAzanov NikAzanov Awaiting requested review from NikAzanov NikAzanov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yalef @ron8mcr