Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad translation string format #1622

Merged
merged 5 commits into from Sep 13, 2023
Merged

Fix bad translation string format #1622

merged 5 commits into from Sep 13, 2023

Conversation

matthewhegarty
Copy link
Contributor

Problem

issue #1567

Solution

Reformatted string as per best practice

Acceptance Criteria

I added a test for this.

Also manually tested before / after by setting LANGUAGE_CODE in settings.py

BEFORE

Screenshot 2023-09-12 at 15 20 59

AFTER

Screenshot 2023-09-12 at 15 23 03

@matthewhegarty matthewhegarty linked an issue Sep 12, 2023 that may be closed by this pull request
Admin form error does not render translations correctly #1567
Closed
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 5899b1d on matthewhegarty:issue-1567-bad-translation-string-format into c2b2f1e on django-import-export:main.

pokken-magic
pokken-magic reviewed Sep 13, 2023
View reviewed changes
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense! Learn something new every day! I didn't know we had localization. Thanks for doing this.

@matthewhegarty matthewhegarty merged commit 15e4267 into django-import-export:main Sep 13, 2023
6 checks passed
@matthewhegarty matthewhegarty deleted the issue-1567-bad-translation-string-format branch September 13, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokken-magic pokken-magic pokken-magic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin form error does not render translations correctly
3 participants
@matthewhegarty @coveralls @pokken-magic