Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v4 #1632

Merged
merged 165 commits into from Apr 28, 2024
Merged

Release v4 #1632

merged 165 commits into from Apr 28, 2024

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Sep 16, 2023 •
edited

Problem

PR for v4 release

  • Removed MANIFEST.in - no longer required when using setuptools-scm
  • Updated coveralls in CI to use github action because cannot import name 'Reporter' from 'coverage.report' when coverage[toml] added.
  • Renamed django-import-export-ci.yml to test.yml (name better reflects purpose of workflow)

TODO

  • Remove pypi and testpypi tokens (and also from github repo) - no longer required.
  • Remove coveralls token (if there is one) no longer required for OSS ?
  • Configure pypi to receive publish events
  • Handle log_action deprecation warning

Build and CI changes

  • coverage / github / coveralls is horrendously buggy
  • it takes hours of tinkering to get something which works together
  • using pyproject.toml to configure coverage means importing coverage[toml], but this breaks reporting with an error
  • I upgraded to github action coverallsapp, but this does not report full coverage (even though it is there)
  • I added 'branch = true' to pyproject.toml, but this breaks reporting
  • Reverted to as close as I could to current working version, which meant added .coveragerc

@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 15:17 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 16:15 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 16:23 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 16:29 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 16:31 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 17:58 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 18:27 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 18:29 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 18:46 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 17, 2023 •
edited

Coverage Status

coverage: 99.903% (-0.1%) from 100.0%
when pulling 6ce4921 on release-4
into 493ff3c on main.

@matthewhegarty matthewhegarty temporarily deployed to testpypi September 17, 2023 18:57 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 11:26 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 11:55 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 12:15 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 13:24 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 13:43 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 13:56 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 14:18 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 14:36 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 14:49 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 15:15 — with GitHub Actions Inactive
@matthewhegarty matthewhegarty temporarily deployed to testpypi September 18, 2023 15:43 — with GitHub Actions Inactive
@matthewhegarty
Refactor build process (#1630)
d51d1bf 
* ported flake8 config to tox.ini

* [pre-commit.ci lite] apply automatic fixes

* updated changelog

* updated config

* fixed formatting issues

* added missing changelog entry

* replaced tox.ini with .flake8

* updated changelog

* added release workflow

* documentation update

* removed whitespace

* added test branch

* corrected branch name

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

added no-local-version

updated config

added fetch-depth

corrected param

adding build debug

updated init

added debug

test init

build fix

corrected version

updated pyproject toml

removed debug

removed MANIFEST.in

updated to add toml support to coverage

added toml support to coverage install

corrected coverage declaration

updated coveralls

coveralls test

removed broken install

coveralls fix attempt

re-added commented code

omit __init__.py from coverage

coverage config update

use env var

env var check

updated test workflow

added debug

attempted config rollback

added branch covarge

config attempt

using .coveragerc

added omit syntax

disabled branch checks
matthewhegarty and others added 8 commits April 3, 2024 16:14
@matthewhegarty
updated documentation for creating test application
3377f8f
@Viicos
Remove unneeded format method overrides (#1785)
0bc7a70 
* Remove unneeded `TSV.create_dataset` override

* Remove unneeded `HTML.export_data`
@matthewhegarty
Fix for incorrect header order on 'confirm' page (#1786)
a4cce66 
* updated test

* test fix

* test fix

* fix for diff header order

* added deprecation warning

* updated changelog
@matthewhegarty
Merge branch 'main' into release-4
2863257
@matthewhegarty
Merge branch 'main' into release-4
5906a09
@matthewhegarty
Support dynamic selection of Resource class based on request property (…
4137220 
…#1787)

* updated mixin method interface

* updated changelog

* standardise methods

* updated method args

* updated method args

* updated release notes

* param updates

* corrected method calls

* fixed method calls
@matthewhegarty
updated release notes
6a63dcb
@matthewhegarty
updated changelog
f97d49f
matthewhegarty and others added 2 commits April 13, 2024 14:38
@matthewhegarty
updated changelog release date
046a827
@matthewhegarty
Remove support for django 3.2 (#1790)
f75adc0 
* Removed support for django 3.2

* updated changelog

* fixed tox

* updated tox

* updated action versions

* updated changelog

* update gh actions version

* Update test.yml

* Update pre-commit.yml

* updated versions
@bluetech
Copy link
Contributor

@matthewhegarty I don't know if you're looking for feedback on v4 yet, but in case you do: calling Widget.render(..., obj) with obj != None is deprecated, but Field.export() calls return self.widget.render(value, instance) with instance != None which triggers the deprecation warning.

Other than that I didn't notice any issues :)

@matthewhegarty
Copy link
Contributor Author

Thank you - feedback very welcome - I will take a look

@matthewhegarty matthewhegarty mentioned this pull request Apr 24, 2024
Merged
matthewhegarty and others added 8 commits April 25, 2024 10:29
@matthewhegarty
Remove widget instance deprecation warning (#1794)
475b00f 
* removed passing 'instance' to widget render() and removed deprecation warnings

* updated release notes

* updated release notes link
@matthewhegarty
added links to release-4 docs
56f9f51
@matthewhegarty
added links to all changelog entries were possible
300d84f
@matthewhegarty
reformatted changelog
09c3058
@radiophysicist
Update translations for Russian language (#1798)
71e79df 
* t

* Update translation for russian language

---------

Co-authored-by: Denis Shatov <denis.shatov@x5.ru>
@mishka251
Fix #1793 and test creating widgets for model fields (#1795)
5f4fbb1 
* Add test for #1793

* Fix flake

* Move test model to models

* Fix test starting

* Fix test

* Extract method for collecting fields

* Fix #1793

* Fix old django version

* Fix old django version

* Fix for main django version

* Fix migration

* update changelog

* update authors

* Fix changelog issue link => PR link

* Fix PR conversations

* Fix changelog
@matthewhegarty
Merge branch 'main' into release-4
929f52a
@matthewhegarty
updated changelog
45ee483
@matthewhegarty matthewhegarty marked this pull request as ready for review April 26, 2024 19:22
@matthewhegarty matthewhegarty merged commit 6db364b into main Apr 28, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet