Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show exported fields in admin #1685

Merged
merged 6 commits into from Nov 17, 2023
Merged

show exported fields in admin #1685

merged 6 commits into from Nov 17, 2023

Conversation

tal66
Copy link
Contributor

@tal66 tal66 commented Nov 16, 2023

hi, this should close #1683.

image

matthewhegarty
matthewhegarty requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. I have suggested a couple of minor changes.

Feel free to add your name to AUTHORS and to add an entry in changelog.rst 👍

import_export/admin.py Show resolved Hide resolved
import_export/templates/admin/import_export/export.html Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 16, 2023 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling 5e5b5fb on tal66:show-exported-fields
into f7decaa on django-import-export:main.

matthewhegarty
matthewhegarty requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - have made some minor comments

import_export/templates/admin/import_export/resource_fields_list.html Show resolved Hide resolved
tests/core/tests/test_admin_integration.py Outdated Show resolved Hide resolved
matthewhegarty
matthewhegarty approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking the time to submit this PR - very much appreciated.

@matthewhegarty matthewhegarty merged commit ebf58e0 into django-import-export:main Nov 17, 2023
5 checks passed
@matthewhegarty matthewhegarty mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export confirm page does not show the list of fields to be exported
3 participants
@tal66 @coveralls @matthewhegarty