Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass get_export_resource_kwargs() to Resource constructor #1739

Merged
merged 2 commits into from Jan 17, 2024
Merged

pass get_export_resource_kwargs() to Resource constructor #1739

merged 2 commits into from Jan 17, 2024

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1738

Solution

Pass get_export_resource_kwargs() to Resource constructor to code block added in #1685.

Acceptance Criteria

  • Added test
  • Manual testing

@coveralls
Copy link

coveralls commented Jan 15, 2024 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling 00e322d on matthewhegarty:issue-1738-get-resource-kwargs
into b19329a on django-import-export:main.

RobTilton
RobTilton reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@RobTilton RobTilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with this.

@matthewhegarty matthewhegarty merged commit eabba74 into django-import-export:main Jan 17, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1738-get-resource-kwargs branch January 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobTilton RobTilton RobTilton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource is not being created with resource kwargs when showing export fields on admin UI
3 participants
@matthewhegarty @coveralls @RobTilton