Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #612: NumberWidget.is_empty() should strip the value if string type #613

Merged
merged 2 commits into from May 17, 2018
Merged

Fix #612: NumberWidget.is_empty() should strip the value if string type #613

merged 2 commits into from May 17, 2018

Conversation

KenyaDonDraper
Copy link
Contributor

No description provided.

@KenyaDonDraper KenyaDonDraper mentioned this pull request Jun 23, 2017
Closed
@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 26, 2017 •
edited

@KenyaDonDraper This looks great, thanks for doing this and especially for the unit tests!

I'm a little hesitant to add whitespace .strip()ping by default, but there is precedence with #668 so I think this is fine. We might want to do this with dates, and generically for any other non-string typed Widgets too. @bmihelac do you think perhaps this kindof cleanup should be able to be enabled/disabled?

@bmihelac
Copy link
Member

This looks good to me. I do not see any downside of removing whitespace always for specific widgets.

@bmihelac bmihelac merged commit 748a460 into django-import-export:master May 17, 2018
@bmihelac
Copy link
Member

merged, thanks!

@KenyaDonDraper KenyaDonDraper deleted the fix-612-strip-string-type-value-in-numberwidget-is-empty-check branch May 31, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrdcm mgrdcm mgrdcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KenyaDonDraper @mgrdcm @bmihelac