Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip whitespace when looking up ManyToMany fields #668

Merged
merged 1 commit into from Nov 16, 2017

Conversation

raghavsethi
Copy link
Contributor

This makes imports more robust when users enter whitespaces after
commas.

This makes imports more robust when users enter whitespaces after
commas.
@raghavsethi
Copy link
Contributor Author

Sorry, I couldn't find the develop branch here https://github.com/django-import-export/django-import-export/branches/all what am I missing?

@raghavsethi
Copy link
Contributor Author

raghavsethi commented Oct 13, 2017

@bmihelac: Would love to know if this is something you want to merge quickly (after I address all your feedback, of course), if not I can subclass ManyToManyWidget for my current project.

@manelclos
Copy link
Contributor

LGTM

@bmihelac bmihelac merged commit 5af5574 into django-import-export:master Nov 16, 2017
@bmihelac
Copy link
Member

Merged, thanks @raghavsethi for patch, @manelclos for reviewing

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 16, 2017

@bmihelac
Copy link
Member

looking into it, thanks for noticing

@bmihelac bmihelac self-assigned this Nov 16, 2017
@bmihelac
Copy link
Member

Fix in d6615a7, sorry for inconvinience

@raghavsethi
Copy link
Contributor Author

Sorry about that! Thanks for the fix!

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 16, 2017

Sorry @bmihelac I would have fixed but was looking at the Travis-CI issue instead :)

@bmihelac
Copy link
Member

No problem @raghavsethi, I checked the code and was confident, travis would warn if anything is wrong.
@mgrdcm it is right for me to fix, since i broke it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants