New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip whitespace when looking up ManyToMany fields #668
Conversation
This makes imports more robust when users enter whitespaces after commas.
Sorry, I couldn't find the |
@bmihelac: Would love to know if this is something you want to merge quickly (after I address all your feedback, of course), if not I can subclass ManyToManyWidget for my current project. |
LGTM |
Merged, thanks @raghavsethi for patch, @manelclos for reviewing |
Uh oh @bmihelac! This is causing tests to fail: https://travis-ci.org/django-import-export/django-import-export/jobs/302923330 |
looking into it, thanks for noticing |
Fix in d6615a7, sorry for inconvinience |
Sorry about that! Thanks for the fix! |
Sorry @bmihelac I would have fixed but was looking at the Travis-CI issue instead :) |
No problem @raghavsethi, I checked the code and was confident, travis would warn if anything is wrong. |
This makes imports more robust when users enter whitespaces after
commas.