Optimize how updates are done in _save() method #198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-ldapdb
library always issues anldap.MOD_REPLACE
request to the LDAP server when saving an updated LDAP entry. This can cause big delays in some cases.Imagine you have a model representing a LDAP group with a field of type
ListField
. That field is used to store the group members. If your group has thousands of members, when you add/remove a memberdjango-ldapdb
sends the whole list of members (thousands) to the LDAP server.This PR sends ldap.MOD_REPLACE, ldap.MOD_DELETE or ldap.MOD_ADD depending on
how the value changes instead of always sending ldap.MOD_REPLACE.