Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annoying print when tests run. #108

Closed
wants to merge 1 commit into from
Closed

Remove annoying print when tests run. #108

wants to merge 1 commit into from

Conversation

k-bx
Copy link

@k-bx k-bx commented Feb 29, 2012

Remove annoying "Installing indicies for ..." prints when running tests.

@flaper87
Copy link
Member

This is part of the syncdb output, I don't think it will be removed! It'd be like removing the creating tables messages!

That's the only output people have from mongodb-engine and it explicitly says that a collection was created in order to satisfy the indexes need. We could change the message and make it more detailed though!

@k-bx
Copy link
Author

k-bx commented Feb 29, 2012

Maybe I am missing something, but django itself (sql) does not print anything. Why should django_mongodb_engine do that then?

The problem is that when I run tests because of django mongodb engine I see http://dl.dropbox.com/u/865508/%D0%92%D1%8B%D0%B4%D0%B5%D0%BB%D0%B5%D0%BD%D0%B8%D0%B5_350.png

While without this print everything is fine: http://dl.dropbox.com/u/865508/%D0%92%D1%8B%D0%B4%D0%B5%D0%BB%D0%B5%D0%BD%D0%B8%D0%B5_351.png

@k-bx
Copy link
Author

k-bx commented Feb 29, 2012

Ok, got it. We need to somehow just change the code to only print when verbosity >= 2 (like django does). Ok, I'll look at it later and will modify the code.

You can discard this pull request, let's do this in a proper way :)

@jonashaag
Copy link
Contributor

Great, thanks! Make sure to mention #108 in the new pull request.

@jonashaag jonashaag closed this Feb 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants