Merge branch drop-support-django1.6 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…django1.6 Drop support for Django 1.6 and below (Django 1.9 not supported yet)
…rt-django1.6 Django 1.9 compability
…django1.6 Fix a RemovedInDjango110Warning in unittest
Fix pep8 & use setuptools
fix doc import signals
Conflicts: notifications/__init__.py notifications/templatetags/notifications_tags.py notifications/tests/settings.py notifications/tests/urls.py setup.py
|
@zhang-z Wonderful job! I can confirm following changes are fine:
Tests were passed by running @LegoStormtroopr can you take a look at |
|
@zhang-z @LegoStormtroopr I've compared So I'm gonna to merge this PR. |
yangyubo
added a commit
that referenced
this pull request
Dec 17, 2015
Merge branch drop-support-django1.6
|
Sorry about that, I had a read and it looked ok, I hadn't had a chance to run tests, but as you said it was all PEP8 changes. Thanks. Merry Christmas 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.