list all notification + before filter #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohannadsh
approved these changes
Dec 4, 2016
| menu.innerHTML = ""; | ||
| for (var i=0; i < data.all_list.length; i++) { | ||
| var item = data.all_list[i]; | ||
| console.log(item) |
There was a problem hiding this comment.
@GhalebKhaled remove log message please.
|
@GhalebKhaled Travis CI was failed, could you please give a glance at it? |
danaspiegel
suggested changes
Dec 8, 2016
| return JsonResponse(data) | ||
|
|
||
| try: | ||
| num_to_fetch = request.GET.get('max', 5) # If they don't specify, make it 5. |
There was a problem hiding this comment.
this will feel a lot simpler if you combine it all into 1 line instead of 4:
min(max(1, int(request.GET.get('max', 5))), 100)
|
|
||
| all_list = [] | ||
|
|
||
| all_notifications_qa = request.user.notifications.all() |
There was a problem hiding this comment.
I think you should drop the _qa postfix. its unnecessary
| for n in all_notifications_qa[0:num_to_fetch]: | ||
| struct = model_to_dict(n) | ||
| if n.actor: | ||
| struct['actor'] = str(n.actor) |
There was a problem hiding this comment.
these should be unicode casts. but also, why cast at all. these should already be strings...
| all_notifications_qa = all_notifications_qa.filter(timestamp__lt=dateutil.parser.parse(before_datetime)) | ||
|
|
||
|
|
||
| for n in all_notifications_qa[0:num_to_fetch]: |
|
Sorry @GhalebKhaled, i can't acept this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
List all notifications (both read/unread)
Add
beforefilter so it can used toshow moreaction