Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update queryset methods mark_as_sent() and mark_as_unsent() #183

Merged
merged 1 commit into from
Aug 1, 2017
Merged

update queryset methods mark_as_sent() and mark_as_unsent() #183

merged 1 commit into from
Aug 1, 2017

Conversation

r26zhao
Copy link
Contributor

@r26zhao r26zhao commented Aug 1, 2017 •
edited

it will raise error local variable 'qs' referenced before assignment, if recipient is not provided when using the query method mark_as_sent and mark_as_unsent.

@coveralls
Copy link

coveralls commented Aug 1, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 93.284% when pulling cf0a11d on r26zhao:master into aeb89dc on django-notifications:master.

@AlvaroLQueiroz
Copy link
Contributor

Thanks @r26zhao

@AlvaroLQueiroz AlvaroLQueiroz merged commit 18db83b into django-notifications:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r26zhao @coveralls @AlvaroLQueiroz