Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an app_label to Notifications model class #86

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Added an app_label to Notifications model class #86

merged 1 commit into from
Dec 1, 2015

Conversation

Heldroe
Copy link
Contributor

@Heldroe Heldroe commented Nov 30, 2015

The lack of app_label in the latest version was throwing a deprecation warning:

/notifications/models.py:131: RemovedInDjango19Warning: Model class notifications.models.Notification doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.

This change fixes the warning.

yangyubo added a commit that referenced this pull request Dec 1, 2015
@yangyubo
Merge pull request #86 from Heldroe/master
32f54e0 
Added an app_label to Notifications model class
@yangyubo yangyubo merged commit 32f54e0 into django-notifications:master Dec 1, 2015
@yangyubo
Copy link
Member

yangyubo commented Dec 1, 2015

@Heldroe Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Heldroe @yangyubo