Moved doc dependencies to docs/requirements.txt

So we can really pin the django version for example
django-oscar · Dec 20, 2019 · 6ff8b6e · 6ff8b6e
1 parent aa79abe
commit 6ff8b6e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/.readthedocs.yml b/.readthedocs.yml
@@ -6,7 +6,6 @@ sphinx:
 python:
    version: 3.7
    install:
+      - requirements: docs/requirements.txt
       - method: pip
         path: .
-        extra_requirements:
-           - docs
diff --git a/Makefile b/Makefile
@@ -8,7 +8,7 @@ clean:
 	rm -Rf build/
 
 install:
-	pip install -e .[dev,docs]
+	pip install -e .[dev,lint]
 
 sandbox: install
 	python sandbox/manage.py migrate
@@ -30,7 +30,8 @@ docker-build:
 docker-coverage: docker-build
 	 docker run -ti -v $(CURDIR):/opt -w /opt oscarapi/test bash -c "make install && pip install 'Django<3' && /usr/bin/make coverage"
 
-docs: install
+docs:
+	pip install -r docs/requirements.txt
 	cd docs && make clean && make html
 
 build_release: clean

diff --git a/docs/requirements.txt b/docs/requirements.txt
@@ -0,0 +1,3 @@
+Django<3
+sphinx
+sphinx_rtd_theme
diff --git a/setup.py b/setup.py
@@ -55,6 +55,5 @@
     extras_require={
         "dev": ["coverage", "mock", "twine", "wheel"],
         "lint": ["flake8", "flake8-black", "flake8-bugbear", "black>=19.10b0"],
-        "docs": ["sphinx", "sphinx_rtd_theme", "Django<3"],
     },
 )