Since shipping_address is not required in the serializer it is very v…

…ery very very very very very very unwise to assume it is present in validated_data
django-oscar · Dec 15, 2017 · 8c75c9d · 8c75c9d
1 parent 1b5342d
commit 8c75c9d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/oscarapi/serializers/checkout.py b/oscarapi/serializers/checkout.py
@@ -273,8 +273,11 @@ def create(self, validated_data):
             order_number = self.generate_order_number(basket)
             request = self.context['request']
 
-            shipping_address = ShippingAddress(
-                **validated_data['shipping_address'])
+            if 'shipping_address' in validated_data:
+                shipping_address = ShippingAddress(
+                    **validated_data['shipping_address'])
+            else:
+                shipping_address = None
 
             if 'billing_address' in validated_data:
                 billing_address = BillingAddress(