Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oscar has refactored the Basket's discounts #17

Closed
XMLSDK opened this issue Apr 9, 2013 · 1 comment
Closed

Oscar has refactored the Basket's discounts #17

XMLSDK opened this issue Apr 9, 2013 · 1 comment

Comments

@XMLSDK
Copy link

XMLSDK commented Apr 9, 2013 

AttributeError at /checkout/paypal/payment/
'Basket' object has no attribute 'get_discounts'

get_discounts looks like changed to offer_applications
@codeinthehole
Copy link
Contributor

Hmm, yes, good point.

It looks like django-oscar-paypal 0.3.* is incompatiable with django-oscar 0.5. I'll have a look into what the right solution is - I suspect we shoudl just limit the 0.3 releases to only work with oscar < 0.5.

codeinthehole added a commit that referenced this issue Apr 10, 2013
@codeinthehole
Update submission of discounts for PayPal Express
ae0bc50 
Oscar 0.5 changes the ways discounts are handled.
This was spotted in #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeinthehole @XMLSDK