Support Oscar 0.6 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #32.
- Only check for shipping address when basket indicates that one would be required.
Changed in Oscar 0.6.
|
I see an other poroblem You can replace
Then, however, i have this error: |
Conflicts: paypal/express/gateway.py paypal/express/views.py
- Pass basket to get_shipping_address - Pass basket to get_shipping_method - Ensure strategies are assigned to reloaded frozen baskets - Use a build_submission method - Pass both values to FixedPrice shipping method - Use renamed bankcard attributes in tests
The folders are required so the image_not_found image can be automatically created.
|
I've fixed the issues arising from changing APIs in Oscar 0.6. Tests are passing and everything seems to be working. I still need to test some US scenarios where tax isn't known in advance. |
| except Basket.DoesNotExist: | ||
| messages.error( | ||
| self.request, | ||
| _("No basket was found that corresponds to your " | ||
| "PayPal transaction")) | ||
| return HttpResponseRedirect(reverse('basket:summary')) | ||
| else: | ||
| # Assign strategy to basket instance | ||
| basket.strategy = Selector().strategy(self.request) |
There was a problem hiding this comment.
Oscar 0.4 & 0.5 don't have selector class
There was a problem hiding this comment.
I think you need it to determine any basket line prices or totals.
We'll probably need to stop supporting 0.4 and 0.5 for the next release.
codeinthehole
added a commit
that referenced
this pull request
Dec 19, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a WIP branch to track progress on supporting Oscar 0.6. It will be finished off and released when Oscar 0.6 is released.
oscar_testsupport