Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Express facade refund/capture/void methods #81

Merged
merged 1 commit into from
Sep 2, 2014

Conversation

bezidejni
Copy link
Contributor

Hi guys,

This is a fix for some of the methods in the PayPal Express facade that are tying to get the transaction ID by the wrong key name and subsequently fail later when sending a request to PayPal with a missing transaction ID.

codeinthehole added a commit that referenced this pull request Sep 2, 2014
Fix for Express facade refund/capture/void methods
@codeinthehole codeinthehole merged commit f28e019 into django-oscar:master Sep 2, 2014
@codeinthehole
Copy link
Contributor

Good catch - thank you.

Not sure why I was using TRANSACTIONID instead of PAYMENTINFO_0_TRANSACTIONID. PayPal's API did tend to duplicate values so perhaps I was using the key that has since been dropped.

I'll cut a new point release with this fix as it's fairly critical.

@codeinthehole
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants