-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add unique_together constraints to ManyToMany through models
Oscar uses explicit through-models for some ManyToMany relationships. The expectation is that for each combinatination of the two foreign keys, only one model can exist. But this hasn't been enforced until now. Fixes #1309.
- Loading branch information
1 parent
c16c210
commit e7c8232
Showing
8 changed files
with
902 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletions
156
...migrations/0021_auto__add_unique_productattributevalue_attribute_product__add_unique_p.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| # -*- coding: utf-8 -*- | ||
| from south.utils import datetime_utils as datetime | ||
| from south.db import db | ||
| from south.v2 import SchemaMigration | ||
| from django.db import models | ||
|
|
||
|
|
||
| class Migration(SchemaMigration): | ||
|
|
||
| def forwards(self, orm): | ||
| # Adding unique constraint on 'ProductAttributeValue', fields ['attribute', 'product'] | ||
| db.create_unique(u'catalogue_productattributevalue', ['attribute_id', 'product_id']) | ||
|
|
||
| # Adding unique constraint on 'ProductRecommendation', fields ['primary', 'recommendation'] | ||
| db.create_unique(u'catalogue_productrecommendation', ['primary_id', 'recommendation_id']) | ||
|
|
||
| # Adding unique constraint on 'ProductCategory', fields ['product', 'category'] | ||
| db.create_unique(u'catalogue_productcategory', ['product_id', 'category_id']) | ||
|
|
||
|
|
||
| def backwards(self, orm): | ||
| # Removing unique constraint on 'ProductCategory', fields ['product', 'category'] | ||
| db.delete_unique(u'catalogue_productcategory', ['product_id', 'category_id']) | ||
|
|
||
| # Removing unique constraint on 'ProductRecommendation', fields ['primary', 'recommendation'] | ||
| db.delete_unique(u'catalogue_productrecommendation', ['primary_id', 'recommendation_id']) | ||
|
|
||
| # Removing unique constraint on 'ProductAttributeValue', fields ['attribute', 'product'] | ||
| db.delete_unique(u'catalogue_productattributevalue', ['attribute_id', 'product_id']) | ||
|
|
||
|
|
||
| models = { | ||
| u'catalogue.attributeentity': { | ||
| 'Meta': {'object_name': 'AttributeEntity'}, | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}), | ||
| 'slug': ('django.db.models.fields.SlugField', [], {'max_length': '255', 'blank': 'True'}), | ||
| 'type': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'entities'", 'to': u"orm['catalogue.AttributeEntityType']"}) | ||
| }, | ||
| u'catalogue.attributeentitytype': { | ||
| 'Meta': {'object_name': 'AttributeEntityType'}, | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}), | ||
| 'slug': ('django.db.models.fields.SlugField', [], {'max_length': '255', 'blank': 'True'}) | ||
| }, | ||
| u'catalogue.attributeoption': { | ||
| 'Meta': {'object_name': 'AttributeOption'}, | ||
| 'group': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'options'", 'to': u"orm['catalogue.AttributeOptionGroup']"}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'option': ('django.db.models.fields.CharField', [], {'max_length': '255'}) | ||
| }, | ||
| u'catalogue.attributeoptiongroup': { | ||
| 'Meta': {'object_name': 'AttributeOptionGroup'}, | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '128'}) | ||
| }, | ||
| u'catalogue.category': { | ||
| 'Meta': {'ordering': "['full_name']", 'object_name': 'Category'}, | ||
| 'depth': ('django.db.models.fields.PositiveIntegerField', [], {}), | ||
| 'description': ('django.db.models.fields.TextField', [], {'blank': 'True'}), | ||
| 'full_name': ('django.db.models.fields.CharField', [], {'max_length': '255', 'db_index': 'True'}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'image': ('django.db.models.fields.files.ImageField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '255', 'db_index': 'True'}), | ||
| 'numchild': ('django.db.models.fields.PositiveIntegerField', [], {'default': '0'}), | ||
| 'path': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '255'}), | ||
| 'slug': ('django.db.models.fields.SlugField', [], {'max_length': '255'}) | ||
| }, | ||
| u'catalogue.option': { | ||
| 'Meta': {'object_name': 'Option'}, | ||
| 'code': ('oscar.models.fields.autoslugfield.AutoSlugField', [], {'allow_duplicates': 'False', 'max_length': '128', 'separator': "u'-'", 'blank': 'True', 'unique': 'True', 'populate_from': "'name'", 'overwrite': 'False'}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '128'}), | ||
| 'type': ('django.db.models.fields.CharField', [], {'default': "'Required'", 'max_length': '128'}) | ||
| }, | ||
| u'catalogue.product': { | ||
| 'Meta': {'ordering': "['-date_created']", 'object_name': 'Product'}, | ||
| 'attributes': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['catalogue.ProductAttribute']", 'through': u"orm['catalogue.ProductAttributeValue']", 'symmetrical': 'False'}), | ||
| 'categories': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['catalogue.Category']", 'through': u"orm['catalogue.ProductCategory']", 'symmetrical': 'False'}), | ||
| 'date_created': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}), | ||
| 'date_updated': ('django.db.models.fields.DateTimeField', [], {'auto_now': 'True', 'db_index': 'True', 'blank': 'True'}), | ||
| 'description': ('django.db.models.fields.TextField', [], {'blank': 'True'}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'is_discountable': ('django.db.models.fields.BooleanField', [], {'default': 'True'}), | ||
| 'parent': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'variants'", 'null': 'True', 'to': u"orm['catalogue.Product']"}), | ||
| 'product_class': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'products'", 'null': 'True', 'on_delete': 'models.PROTECT', 'to': u"orm['catalogue.ProductClass']"}), | ||
| 'product_options': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['catalogue.Option']", 'symmetrical': 'False', 'blank': 'True'}), | ||
| 'rating': ('django.db.models.fields.FloatField', [], {'null': 'True'}), | ||
| 'recommended_products': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['catalogue.Product']", 'symmetrical': 'False', 'through': u"orm['catalogue.ProductRecommendation']", 'blank': 'True'}), | ||
| 'related_products': ('django.db.models.fields.related.ManyToManyField', [], {'symmetrical': 'False', 'related_name': "'relations'", 'blank': 'True', 'to': u"orm['catalogue.Product']"}), | ||
| 'score': ('django.db.models.fields.FloatField', [], {'default': '0.0', 'db_index': 'True'}), | ||
| 'slug': ('django.db.models.fields.SlugField', [], {'max_length': '255'}), | ||
| 'title': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}), | ||
| 'upc': ('oscar.models.fields.NullCharField', [], {'max_length': '64', 'unique': 'True', 'null': 'True', 'blank': 'True'}) | ||
| }, | ||
| u'catalogue.productattribute': { | ||
| 'Meta': {'ordering': "['code']", 'object_name': 'ProductAttribute'}, | ||
| 'code': ('django.db.models.fields.SlugField', [], {'max_length': '128'}), | ||
| 'entity_type': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.AttributeEntityType']", 'null': 'True', 'blank': 'True'}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '128'}), | ||
| 'option_group': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.AttributeOptionGroup']", 'null': 'True', 'blank': 'True'}), | ||
| 'product_class': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'attributes'", 'null': 'True', 'to': u"orm['catalogue.ProductClass']"}), | ||
| 'required': ('django.db.models.fields.BooleanField', [], {'default': 'False'}), | ||
| 'type': ('django.db.models.fields.CharField', [], {'default': "'text'", 'max_length': '20'}) | ||
| }, | ||
| u'catalogue.productattributevalue': { | ||
| 'Meta': {'unique_together': "(('attribute', 'product'),)", 'object_name': 'ProductAttributeValue'}, | ||
| 'attribute': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.ProductAttribute']"}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'product': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'attribute_values'", 'to': u"orm['catalogue.Product']"}), | ||
| 'value_boolean': ('django.db.models.fields.NullBooleanField', [], {'null': 'True', 'blank': 'True'}), | ||
| 'value_date': ('django.db.models.fields.DateField', [], {'null': 'True', 'blank': 'True'}), | ||
| 'value_entity': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.AttributeEntity']", 'null': 'True', 'blank': 'True'}), | ||
| 'value_file': ('django.db.models.fields.files.FileField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}), | ||
| 'value_float': ('django.db.models.fields.FloatField', [], {'null': 'True', 'blank': 'True'}), | ||
| 'value_image': ('django.db.models.fields.files.ImageField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}), | ||
| 'value_integer': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}), | ||
| 'value_option': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.AttributeOption']", 'null': 'True', 'blank': 'True'}), | ||
| 'value_richtext': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}), | ||
| 'value_text': ('django.db.models.fields.CharField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}) | ||
| }, | ||
| u'catalogue.productcategory': { | ||
| 'Meta': {'ordering': "['product', 'category']", 'unique_together': "(('product', 'category'),)", 'object_name': 'ProductCategory'}, | ||
| 'category': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.Category']"}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'product': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.Product']"}) | ||
| }, | ||
| u'catalogue.productclass': { | ||
| 'Meta': {'ordering': "['name']", 'object_name': 'ProductClass'}, | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'name': ('django.db.models.fields.CharField', [], {'max_length': '128'}), | ||
| 'options': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['catalogue.Option']", 'symmetrical': 'False', 'blank': 'True'}), | ||
| 'requires_shipping': ('django.db.models.fields.BooleanField', [], {'default': 'True'}), | ||
| 'slug': ('oscar.models.fields.autoslugfield.AutoSlugField', [], {'allow_duplicates': 'False', 'max_length': '128', 'separator': "u'-'", 'blank': 'True', 'unique': 'True', 'populate_from': "'name'", 'overwrite': 'False'}), | ||
| 'track_stock': ('django.db.models.fields.BooleanField', [], {'default': 'True'}) | ||
| }, | ||
| u'catalogue.productimage': { | ||
| 'Meta': {'ordering': "['display_order']", 'unique_together': "(('product', 'display_order'),)", 'object_name': 'ProductImage'}, | ||
| 'caption': ('django.db.models.fields.CharField', [], {'max_length': '200', 'blank': 'True'}), | ||
| 'date_created': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}), | ||
| 'display_order': ('django.db.models.fields.PositiveIntegerField', [], {'default': '0'}), | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'original': ('django.db.models.fields.files.ImageField', [], {'max_length': '255'}), | ||
| 'product': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'images'", 'to': u"orm['catalogue.Product']"}) | ||
| }, | ||
| u'catalogue.productrecommendation': { | ||
| 'Meta': {'unique_together': "(('primary', 'recommendation'),)", 'object_name': 'ProductRecommendation'}, | ||
| u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), | ||
| 'primary': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'primary_recommendations'", 'to': u"orm['catalogue.Product']"}), | ||
| 'ranking': ('django.db.models.fields.PositiveSmallIntegerField', [], {'default': '0'}), | ||
| 'recommendation': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['catalogue.Product']"}) | ||
| } | ||
| } | ||
|
|
||
| complete_apps = ['catalogue'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.