Skip to content

Commit

Permalink
Default value for HTTP_REFERER in BulkEditMixin
Browse files Browse the repository at this point in the history
Avoids a key error when a referer is not available.

Also removed BulkEditMixin from the PartnerListView as it was not used.
  • Loading branch information
maiksprenger committed Jun 7, 2013
1 parent 042bff9 commit f9f5117
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions oscar/apps/dashboard/partners/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@

from oscar.apps.dashboard.partners.forms import UserEmailForm, ExistingUserForm, NewUserForm
from oscar.core.loading import get_classes
from oscar.views.generic import BulkEditMixin

Partner = get_model('partner', 'Partner')
PartnerSearchForm, PartnerCreateForm = get_classes(
'dashboard.partners.forms', ['PartnerSearchForm', 'PartnerCreateForm'])


class PartnerListView(generic.ListView, BulkEditMixin):
class PartnerListView(generic.ListView):
model = Partner
context_object_name = 'partners'
template_name = 'dashboard/partners/partner_list.html'
Expand Down
4 changes: 2 additions & 2 deletions oscar/views/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ def get_queryset(self):
pass

def get_error_url(self, request):
return request.META['HTTP_REFERER']
return request.META.get('HTTP_REFERER', '.')

def get_success_url(self, request):
return request.META['HTTP_REFERER']
return request.META('HTTP_REFERER', '.')

def post(self, request, *args, **kwargs):
# Dynamic dispatch pattern - we forward POST requests onto a method
Expand Down

0 comments on commit f9f5117

Please sign in to comment.