Fix dashboard navigation permissions #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly construct Node while filtering The original code didn't pass icon, and change access_fn for url_args. - Filter child nodes
|
Agreed, those were issues I spotted and fixed when doing the dynamic menu for the permission-based dashboard. I'll let @codeinthehole merge it as I presume it'll require a release? |
maiksprenger
added a commit
that referenced
this pull request
Apr 1, 2014
Fix dashboard navigation permissions
|
Merged. You can bug @codeinthehole for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code didn't pass icon, and change access_fn for url_args.