Update checkout tests with new factories

[itbabu]

I added fuctional tests to some checkout views: IndexView, ShippingAddressView, UserAddressUpdateView and DeleteUserAddressView.

There are some views left but in the meantime a test highlights that phonenumber is not working as expected with Python 3 and Django 1.6

    def test_submitting_valid_form_modifies_user_address(self):
        page = self.get(reverse('checkout:user-address-update', kwargs={'pk': self.user_address.pk}),
                        user=self.user)
        form = page.forms['update_user_address']
        form['first_name'] = 'Tom'
        response = form.submit()
        self.assertRedirectUrlName(response, 'checkout:shipping-address')
        self.assertEqual('Tom', UserAddress.objects.get().first_name)

This test will fail:

(Pdb) response
<200 OK text/html body=b'\n\n<!DO...l>\n'/14519>
(Pdb) response.form['phone_number'].value
'Country Code: 49 National Number: 3513296645 Country Code Source: 1 Preferred Domestic Carrier Code: '

It seems that the form is filled with the stringified phone number object and so the submit fails.

(Pdb) response.html
'(...)<span class="error-block"><i class="icon-exclamation-sign"></i> This is not a valid local or international phone format.</span>(...)'

I still have to figure out why this happens

[maiksprenger]

Wow, lovely work. I'm having a look at the phone number issue now.

[maiksprenger]

I lost wifi on the train and then got changed to a train without power outlets... I'll get to look at it on Friday.

[itbabu]

I'll add few more tests in the next days.

Is there a reason to keep both assertRedirectUrlName and assertRedirectsTo assertions?

[maiksprenger]

Marco, you're right, those two helpers are duplicates. I removed one here: 09f66c3

I also had a look at the unused delete code in ShippingAddressView and have to agree with you. As it's not really related to this PR, I took the liberty of cherry-picking it onto master here: 549decb I only modified the commit message.

Thanks for this. I'll investigate the phone number thing after lunch.

[maiksprenger]

@itbabu, why are you suggesting adding unique IDs to the <form>s? I don't think there's harm in it; I'd just like to understand the reasoning.

[itbabu]

@maikhoepfel It simplifes and make more understandable a functional test when we need to select a form inside a page.
Sometimes a page has lot of forms (see these tests: test_can_delete_a_user_address_from_shipping_address_page
test_can_select_an_existing_shipping_address)

There are already some tests in Oscar using this.
For example see

django-oscar/tests/functional/customer/profile_tests.py

Lines 32 to 41 in 485a5d0

	def test_can_delete_their_profile(self):
	user_id = self.user.id
	order_id = self.order.id
	profile = self.app.get(reverse('customer:profile-view'),
	user=self.user)
	delete_confirm = profile.click(linkid="delete_profile")
	form = delete_confirm.forms['delete_profile_form']
	form['password'] = self.password
	form.submit()

[maiksprenger]

@itbabu, thanks for all the work and taking the time to explain.

I just pushed a squashed version of your work in a0ce8f2. Apart from some PEP8 changes and using assertRedirectsTo instead of the removed method, it's unchanged. I also finally managed to track down the bug you found: 9537531

I did quite a bit of cleanup along the way: 7b31081 and ee43070.

With that, I'm closing this PR. You're most welcome to add more tests; please create a new PR for that.