Make product unavailable if price is empty to avoid exception when adding product without price to basket #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we use the pricing policy to determine if a price is available? |
|
@mvantellingen right, I'll move check to pricing policy. But in general, what do you think about solution? |
src/oscar/apps/partner/strategy.py
Outdated
| @@ -204,7 +204,7 @@ class StockRequired(object): | |||
| def availability_policy(self, product, stockrecord): | |||
| if not stockrecord: | |||
| return availability.Unavailable() | |||
| if not product.get_product_class().track_stock: | |||
| if not product.get_product_class().track_stock and stockrecord.price_excl_tax: | |||
There was a problem hiding this comment.
This seems to make products which are free (price is 0) unavailable. Not sure we want, perhaps:
if not stockrecord or stockrecord.price_excl_tax is None:
return availability.Unavailable()
There was a problem hiding this comment.
Right. Otherwise looks good?
sasha0
force-pushed
the
issue/1912/empty_price_excl_tax
branch
from
581227b
to
7abc08a
Compare
|
@mvantellingen updated PR. Please check. |
…ding product without price to basket
sasha0
force-pushed
the
issue/1912/empty_price_excl_tax
branch
from
7abc08a
to
82d9e7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 82.77% 82.77% +<.01%
==========================================
Files 321 321
Lines 15348 15348
==========================================
+ Hits 12704 12705 +1
+ Misses 2644 2643 -1
Continue to review full report at Codecov.
|
This was referenced Apr 14, 2018
MrVoltz
pushed a commit
to EndevelCZ/django-oscar
that referenced
this pull request
Aug 21, 2018
…ce_excl_tax Make product unavailable if price is empty to avoid exception when adding product without price to basket
MrVoltz
pushed a commit
to EndevelCZ/django-oscar
that referenced
this pull request
Aug 21, 2018
Revert changes in django-oscar#1913 and django-oscar#2294 that required a stock record to have price_excl_tax set in order to report the product as available. Add separate checks to the basket form/add logic that checks at the time of adding a product to the basket whether a price exists, and report an error if it doesn't. Fixes django-oscar#2664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1912