Unavailable pricing fixes. #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the `FixedRateTax` and `DeferredTax` pricing strategy mixins.
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
+ Coverage 82.88% 82.94% +0.05%
==========================================
Files 325 325
Lines 15408 15408
==========================================
+ Hits 12771 12780 +9
+ Misses 2637 2628 -9
Continue to review full report at Codecov.
|
This was referenced Apr 14, 2018
MrVoltz
pushed a commit
to EndevelCZ/django-oscar
that referenced
this pull request
Aug 21, 2018
…ble-pricing Unavailable pricing fixes.
MrVoltz
pushed a commit
to EndevelCZ/django-oscar
that referenced
this pull request
Aug 21, 2018
Revert changes in django-oscar#1913 and django-oscar#2294 that required a stock record to have price_excl_tax set in order to report the product as available. Add separate checks to the basket form/add logic that checks at the time of adding a product to the basket whether a price exists, and report an error if it doesn't. Fixes django-oscar#2664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1795.