Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BankcardExpiryMonthField to have required=False #2009

Conversation

john-parton
Copy link
Contributor

Fix for #2008

Should allow for required=False to be set on a BankcardExpiryMonthField.

Test is included.

@john-parton john-parton force-pushed the issue/2008/expirymonth_attribute_error branch from ec5b543 to b6ff55a Compare February 18, 2016 19:21
@john-parton
Copy link
Contributor Author

Had to do a push --force to remove some extra commits that snuck in.

@john-parton john-parton changed the title Issue/2008/expirymonth attribute error Allow BankcardExpiryMonthField to have required=False Feb 18, 2016
@john-parton
Copy link
Contributor Author

Anything I need to do to get this merged?

@sasha0 sasha0 merged commit ca32efe into django-oscar:master Nov 7, 2016
MrVoltz pushed a commit to EndevelCZ/django-oscar that referenced this pull request Aug 21, 2018
…rymonth_attribute_error

Allow BankcardExpiryMonthField to have required=False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants