Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the use of empty and . values for the form action attribute #2708

Merged

Conversation

craigloftus
Copy link
Contributor

Following Django, this commit drops the use of empty action attributes, inline with the HTML5 spec.

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #2708 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2708   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         311      311           
  Lines       15522    15522           
=======================================
  Hits        12983    12983           
  Misses       2539     2539

@solarissmoke
Copy link
Member

For reference, here is the relevant section of the HTML5 specification:

  1. Let action be the submitter element’s action.
  2. If action is the empty string, let action be the document’s URL of the form document.

and:

The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces.

The action of an element is the value of the element’s formaction attribute, if the element is a Submit Button and has such an attribute, or the value of its form owner’s action attribute, if it has one, or else the empty string.

@solarissmoke solarissmoke merged commit edf12d7 into django-oscar:master May 30, 2018
MrVoltz pushed a commit to EndevelCZ/django-oscar that referenced this pull request Aug 21, 2018
…pty-actions

Drop the use of empty and . values for the form action attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants