Make category slugs dashboard-editable. #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3489 +/- ##
=======================================
Coverage 85.17% 85.18%
=======================================
Files 289 289
Lines 15532 15538 +6
=======================================
+ Hits 13230 13236 +6
Misses 2302 2302
|
specialunderwear
requested changes
Sep 4, 2020
| super().__init__(*args, **kwargs) | ||
| if 'slug' in self.fields: | ||
| self.fields['slug'].required = False | ||
| self.fields['slug'].help_text = _('Leave blank to generate from category name') |
There was a problem hiding this comment.
Is this string allready present in the gettext catalog?
There was a problem hiding this comment.
No - but I've been periodically updating the gettext catalog separately from functional changes, because it introduces a huge diff that makes review harder.
auvipy
approved these changes
Sep 5, 2020
specialunderwear
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make category slugs editable from the dashboard, so that admins can modify them if they change a category name etc.
Fixes #561, fixes #3472.