Bulk attributes save #4167
Merged
Bulk attributes save #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4167 +/- ##
==========================================
+ Coverage 87.61% 87.76% +0.15%
==========================================
Files 290 290
Lines 15946 16047 +101
==========================================
+ Hits 13971 14084 +113
+ Misses 1975 1963 -12
|
specialunderwear
force-pushed
the
bulk-attributes-save
branch
from
62f35db
to
fce2df0
Compare
…very hard to import data with oscarapi if this is always required.
joeyjurjens
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of time spent saving oscar products, is in the attributes.
By saving the attributes in bulk, a lot of this overhead can be reduced, which will make everything feel a lot faster.