Front end for detail.html, promotions, widgets, basket.html, checkout nav #642
Conversation
…o-oscar into issue/557/demo
…sing the same js for all carousels, added markup for possible widgets, added checkout navigation, tidied some less(more needed around buttons, navbar)
|
A very minor point, but just put the 'trans' tags around the relevant content. |
|
|
|
|
||
| // Register mobile callback | ||
|
|
||
|
|
||
| // Register desktop callback | ||
| site.responsive.register(megaCarousel, ['desktop', 'tablet']); | ||
| site.responsive.register(productCarousel, ['desktop', 'tablet']); | ||
| site.responsive.register(productSingleCarousel, ['desktop', 'tablet']); | ||
|
|
||
| }(site, jQuery)); |
There was a problem hiding this comment.
Should any of these JS changes go back into core?
There was a problem hiding this comment.
Well there are a few things I would put into the core from demo.
- Replace elastislide and gallery JS with flexslider for all carousels (added into demo)
- I like this way of calling responsive js too (although instead of the above code I could have set carousels to display one item rather than disable)
- I created a feature product promotion - which uses singleproductpromotion code as a carousel (pretty useful)
- Review STARS I have replaced with icons (on product lists and product page)
- Product page has variants feeding in.
- Product lists are better with availability - ie with buttons buy, view range (if children), out of stock (or notify me), or not available badge.
Just thoughts anyway
There was a problem hiding this comment.
Oh - the shipping page markup / and styles are better in my opinion. Shipping address page - with or without addresses. We need to add more {% block %}s in the checkout area - so we don't need to duplicate templates so much.
There was a problem hiding this comment.
That all sounds fine to me. I guess it would need to be you who extracts the relevant changes into a new pull request - shall I create a ticket?
There was a problem hiding this comment.
Yeah sure create a ticket and assign to me. Not to sure about when it will get done -- I think we need to finish off the demo site first. We really need to think of a way to separate fancypage statics from the front end too -- as it is a little tricky. Also had problems with icons font-awesome conflicting with icomoon, from fancypages and site frontend.
Front end for detail.html, promotions, widgets, basket.html, checkout nav
|
Splendid work. Can I be a total pedant and ask that you try and follow these guidelines with commit messages: The most important one is having a short summary as the first line. It makes lists of commits much easier to read in the logs and through Github's UI (look at the commits here: https://github.com/tangentlabs/django-oscar/pull/557). Another trick for keeping a clean history is to pull in new commits with `git pull --rebase |
|
Thanks @codeinthehole -- I will try your tips in my future pulls and pushes. |
Really sorry for the large commit!
Styling/markup for:
Carousels: now using the same js
Added markup for possible widgets
Added checkout navigation.
Tidied some less (more needed around buttons, navbar)