Add support for passing an image parameter in the otpauth URL. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timw6n
commented
May 11, 2023
| issuer = issuer.replace(':', '') | ||
| label = '{}:{}'.format(issuer, label) | ||
| urlencoded_params += '&issuer={}'.format( | ||
| quote(issuer) | ||
| ) # encode issuer as per RFC 3986, not quote_plus | ||
|
|
||
| image = self._read_str_from_settings('OTP_TOTP_IMAGE') | ||
| if image: | ||
| urlencoded_params += "&image={}".format(quote(image, safe=':/')) |
There was a problem hiding this comment.
The inclusion of : in the safe characters set is to match the tested logic I'm currently using to append this parameter to the URL string before making a QR code.
|
Thank you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some authenticator applications (most notably FreeOTP) support this additional parameter in the
otpauthURL.This MR adds it using basically the same logic as is used for the
issuerparameter.