Proxy NGINX is not sending REMOTE_ADDR - not working on production. #251 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitis
changed the title
hvitis
changed the title
hvitis
changed the title
|
Could some package author merge this pull request? I implemented those changes in my small app and now it is working. Many thanks @hvitis!
|
|
Please search existing similar PRs. This is very similar to #60 and suffers same problems outlined in #60 (comment) . Furthermore, wouldn't this change break support for IPv6 addresses amongst others? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX can block requests by default or it might be not yet set up on production env.
Additionally some requests or settings can wrongly pass the IP so it needs to be verified.
Finally, the IP needs to always be set due to default restrictions on models. GenericIPAddressField(_('ip address'))