242 allow optional fields in verified notifications #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraciunoiu
approved these changes
Apr 2, 2022
|
Thank you for the fast-follow! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR, maybe 15 lines or so, that reverts one of the changes I made in #239. In that PR, I took a risk by replacing a
dict.get()with a key lookup instead (dict[some-key]). Well, sure enough there are indeed notifications that lack certain fields, so, fine, we'll use aget(), like we did before.Also bumps the version, so should be easy to deploy with a tagged commit.
Sorry for the churn. Hopefully this will be it.