Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving add_child error #234

Closed
wants to merge 3 commits into from
Closed

Conversation

hazho
Copy link

@hazho hazho commented Oct 2, 2021

solved issues:
#140
#220

treebeard/mp_tree.py Outdated Show resolved Hide resolved
treebeard/mp_tree.py Outdated Show resolved Hide resolved
thanks to @graingert

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
treebeard/mp_tree.py Outdated Show resolved Hide resolved
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Copy link
Collaborator

@solarissmoke solarissmoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some unit tests to verify that this fixes the original issues described?

@hazho
Copy link
Author

hazho commented Oct 22, 2021

Could you please add some unit tests to verify that this fixes the original issues described?

@solarissmoke I'm not so expert in unit_tests, kindly check #235

@hazho hazho closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants